Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging #49

Merged
merged 9 commits into from
Feb 29, 2024
Merged

Tagging #49

merged 9 commits into from
Feb 29, 2024

Conversation

sersorrel
Copy link
Member

Environments now have tags, which you can specify at build time or add afterwards via the addTag GraphQL mutation. These are stored in a new meta.yml (the idea being that softpack.yml should never change, but metadata like tags may be mutated over time as environments are categorised in new ways).

@sersorrel sersorrel requested review from sb10 and mjkw31 February 29, 2024 14:55
@sersorrel sersorrel requested a review from altaf-ali as a code owner February 29, 2024 14:55
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 26.92308% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 60.04%. Comparing base (c610828) to head (252b48c).

Files Patch % Lines
softpack_core/schemas/environment.py 27.27% 32 Missing ⚠️
softpack_core/artifacts.py 28.57% 5 Missing ⚠️
softpack_core/service.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
- Coverage    61.83%   60.04%   -1.79%     
===========================================
  Files           17       17              
  Lines          896      941      +45     
  Branches       163      175      +12     
===========================================
+ Hits           554      565      +11     
- Misses         335      369      +34     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sb10 sb10 merged commit 0d39193 into develop Feb 29, 2024
3 of 5 checks passed
@sb10 sb10 deleted the tagging branch February 29, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants