Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify a branch to serve on #51

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Add option to specify a branch to serve on #51

merged 4 commits into from
Apr 4, 2024

Conversation

y-popov
Copy link
Contributor

@y-popov y-popov commented Apr 3, 2024

No description provided.

@y-popov y-popov requested review from mjkw31 and sb10 April 3, 2024 13:40
@y-popov
Copy link
Contributor Author

y-popov commented Apr 3, 2024

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (d8e41f3) to head (d4252c4).

Files Patch % Lines
softpack_core/schemas/environment.py 5.88% 16 Missing ⚠️
softpack_core/artifacts.py 36.84% 11 Missing and 1 partial ⚠️
softpack_core/service.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
- Coverage    59.85%   59.00%   -0.86%     
===========================================
  Files           17       17              
  Lines          944      961      +17     
  Branches       175      177       +2     
===========================================
+ Hits           565      567       +2     
- Misses         372      385      +13     
- Partials         7        9       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sb10 sb10 merged commit 21cfb11 into develop Apr 4, 2024
3 of 5 checks passed
@sb10 sb10 deleted the branch-option branch April 4, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants