Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment hiding #55

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Environment hiding #55

merged 3 commits into from
Aug 20, 2024

Conversation

donnybeelo
Copy link
Contributor

No description provided.

mjkw31 added 2 commits August 5, 2024 13:55
* Allow test LDAP username to be supplied with an environmental variable.

* Reformatted.

* Remove broken tests.

* Remove unused fixtures.
* Add endpoint to hide or unhide an environment in the frontend.

* Add admin only option to force hide an environment.

* Remove force_hide from the Environment type.
@donnybeelo donnybeelo requested a review from sb10 August 14, 2024 12:55
Copy link
Contributor

@sb10 sb10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more time needs to be spent getting the deleted tests to work again...

* Fix unit test for service_run

* Add conftest.py for unit tests and update test_service.py

---------

Co-authored-by: Michael Woolnough <mw31@sanger.ac.uk>
Copy link

cloudflare-workers-and-pages bot commented Aug 20, 2024

Deploying softpack-core with  Cloudflare Pages  Cloudflare Pages

Latest commit: a93c265
Status:🚫  Build failed.

View logs

@sb10 sb10 merged commit a93c265 into main Aug 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants