#250 Add -tags timetzdata to the go build for Windows
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| @@ -33,7 +33,7 @@ install: | |||
| other_build: | |||
| GOARCH=amd64 GOOS=darwin go build --ldflags "${.LD_FLAGS}" -o bin/aem.darwin ./cmd/aem | |||
| GOARCH=amd64 GOOS=linux go build --ldflags "${.LD_FLAGS}" -o bin/aem.linux ./cmd/aem | |||
| GOARCH=amd64 GOOS=windows go build --ldflags "${.LD_FLAGS}" -o bin/aem.exe ./cmd/aem | |||
| GOARCH=amd64 GOOS=windows go build -tags timetzdata --ldflags "${.LD_FLAGS}" -o bin/aem.exe ./cmd/aem | |||
There was a problem hiding this comment.
why only for windows?
There was a problem hiding this comment.
and there is another place to cover for that - https://github.com/wttech/aemc/blob/main/.goreleaser.yaml#L23
There was a problem hiding this comment.
why only for windows?
Only windows lacks the tzdata library
and there is another place to cover for that - https://github.com/wttech/aemc/blob/main/.goreleaser.yaml#L23
Done
There was a problem hiding this comment.
Instead of adding a separate build id.. Hmm maybe just that flag will be ignored when on non-windows OS will be built
There was a problem hiding this comment.
okay, adding this tag for all archs won't hurt
There was a problem hiding this comment.
so align it as well in Makefile ;)
krystian-panek-vmltech
requested changes
Apr 11, 2024
krystian-panek-vmltech
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #250