Do not merge this PR #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
wukongcheng
commented
Apr 29, 2019
wukongcheng
commented
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG.md
Merge with tag 0.26.1-rc0
…Liu/tendermint into irisnet/v0.26.1-rc0-iris
Add reteat last block interface for block store
R4R: automatically shutdown node and enter query-only mode
…trics R4R: Add consensus failure to metrics
R4R: Optimize txs search
R4R: bug fix for evidence check
Patch remote signer to work with the KMS
R4R: Switch fields ordering
R4R: Fix consensus round issue
…other tx insertion
R4R: Add latest tx to the back of cache list
R4R: Add maximum msg size in CheckTx
R4R: add stopMtx for FlushStop and OnStop
R4R: Fix goroutine leak
R4R: fix infinite loop in addrbook
wukongcheng
pushed a commit
that referenced
this pull request
Jan 7, 2020
wukongcheng
pushed a commit
that referenced
this pull request
Mar 24, 2020
* rename adjusted to adjacent Refs tendermint#3989 (comment) * rename ErrTooMuchChange to ErrNotEnoughVotingPowerSigned Refs tendermint#3989 (comment) * verify commit is properly signed * remove no longer trusted headers * restore trustedHeader and trustedNextVals * check trustedHeader using options Refs tendermint#4209 (comment) * use correct var when checking if headers are adjacent in bisection func + replace TODO with a comment tendermint#3989 (comment) * return header in VerifyHeaderAtHeight because that way we avoid DB call + add godoc comments + check if there are no headers yet in AutoClient tendermint#3989 (review) * TestVerifyAdjacentHeaders: add 2 more test-cases + add TestVerifyReturnsErrorIfTrustLevelIsInvalid * lite: avoid overflow when parsing key in db store! * lite: rename AutoClient#Err to Errs * lite: add a test for AutoClient * lite: fix keyPattern and call itr.Next in db store * lite: add two tests for db store * lite: add TestClientRemovesNoLongerTrustedHeaders * lite: test Client#Cleanup * lite: test restoring trustedHeader tendermint#4209 (comment) * lite: comment out unused code in test_helpers * fix TestVerifyReturnsErrorIfTrustLevelIsInvalid after merge * change defaultRemoveNoLongerTrustedHeadersPeriod and add docs * write more doc * lite: uncomment testable examples * use stdlog.Fatal to stop AutoClient tests * make lll linter happy * separate errors for 2 cases - the validator set of a skipped header cannot be trusted, i.e. <1/3rd of h1 validator set has signed (new error, something like ErrNewValSetCantBeTrusted) - the validator set is trusted but < 2/3rds has signed (ErrNewHeaderCantBeTrusted) tendermint#4209 (comment) * remove all headers (even the last one) that are outside of the trusting period. By doing this, we avoid checking the trustedHeader's hash in checkTrustedHeaderUsingOptions (case #1). tendermint#4209 (comment) * explain restoreTrustedHeaderAndNextVals better tendermint#4209 (comment) * add ConfirmationFunction option for optionally prompting for user input Y/n before removing headers Refs tendermint#4209 (comment) * make cleaning optional tendermint#4209 (comment) * return error when user refused to remove headers * check for double votes in VerifyCommitTrusting * leave only ErrNewValSetCantBeTrusted error to differenciate between h2Vals.VerifyCommit and h1NextVals.VerifyCommitTrusting * fix example tests * remove unnecessary if condition tendermint#4209 (comment) It will be handled by the above switch. * verifyCommitBasic does not depend on vals Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.