-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite using new Aperture and n-api #34
base: main
Are you sure you want to change the base?
Conversation
@sindresorhus Any idea why when I ran this with the Building with I didn't have any such issues using the Could we do something similar to Kap, run the build in two workers one for arm and one for intel, generate two Or is there value in keeping the CLI version in general |
Package.swift
Outdated
) | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/wulkano/Aperture", from: "2.0.1"), | ||
.package(url: "https://github.com/apple/swift-argument-parser", from: "1.3.1") | ||
.package(url: "https://github.com/wulkano/Aperture", branch: "george/rewrite-in-screen-capture-kit"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch here should change back to the real version when the Aperture PR is merged/released
Using new properties only works with a new Xcode, which may require the latest macOS image. |
The goal should be to only have the native add-on. Doesn't make sense to maintain both. And the native add-on should be much faster and reliable. |
Sources/ApertureCLI/record.swift
Outdated
@@ -3,30 +3,22 @@ import Aperture | |||
|
|||
struct Options: Decodable { | |||
let destination: URL | |||
let targetId: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let targetId: String? | |
let targetID: String? |
index.d.ts
Outdated
applicationName?: string; | ||
applicationBundleIdentifier?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick (my preference only):
applicationName?: string; | |
applicationBundleIdentifier?: string; | |
appName?: string; | |
appBundleIdentifier?: string; |
@sindresorhus I think this is ready for another review I've managed to build a cross-platform add-on, although we have to use It means that we need this entire I've set up GH actions to build/test in arm Changed the API of the package a bit to have separate entry-points for each target since they have different sets of options. It was either that, or a complex TS overload, figured this was better, but not a strong preference. One thing I'm not sure about is do we need to do anything for ASAR with the add-on path like we did for the CLI? Or is that ok as is with: |
Implements the changes in wulkano/Aperture#80
node-swift
)native.js
export that uses that add-onFor now, kept the other as the default, since the add-on can't be cross-platform compiled until this is released