Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented WMTTemplates #162

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

Implemented WMTTemplates #162

wants to merge 32 commits into from

Conversation

Hopsaheysa
Copy link
Member

@Hopsaheysa Hopsaheysa commented Jun 27, 2024 •
edited
Loading

Fixes: #161

-> in WMTUserOperation there are hardcoded data which can be used for testing purposes by commenting out/uncommenting:

 /// Additional UI data to present
 ///
 /// Additional UI data such as Pre-Approval Screen or Post-Approval Screen should be presented.
 public let ui: WMTOperationUIData?
 // TODO: remove before merging
 ///    public let ui = prepareTemplates(response: uiTemplates)

this shall be deleted before merging

@Hopsaheysa Hopsaheysa requested a review from kober32 July 10, 2024 12:44
@kober32 kober32 changed the base branch from develop to releases/1.10.x July 11, 2024 14:57
@kober32
Copy link
Member

kober32 commented Jul 11, 2024

I temporarily changed the base branch to release/1.10.x to be able to review it before it gets up to date with the develop again...

kober32
kober32 reviewed Jul 11, 2024
View reviewed changes
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTOperationUIData.swift
@@ -33,10 +33,15 @@ open class WMTOperationUIData: Codable {
/// Type of PostApprovalScrren is presented with different classes (Starting with `WMTPostApprovalScreen*`)
public let postApprovalScreen: WMTPostApprovalScreen?

/// Detailed information about displaying the operation data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have documentation for it, we should link it here...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a reminder so we don't forget :)

kober32
kober32 requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK so far, need some changes + I think we need to introduce the parser for the UI to make it easier for the integrator.

WultraMobileTokenSDK/Operations/Model/UserOperation/WMTOperationUIData.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTTemplates.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTTemplates.swift Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTTemplates.swift Outdated Show resolved Hide resolved
@kober32 kober32 changed the base branch from releases/1.10.x to develop July 18, 2024 13:22
@Hopsaheysa Hopsaheysa marked this pull request as ready for review July 26, 2024 09:57
@Hopsaheysa Hopsaheysa requested a review from kober32 July 26, 2024 09:57
kober32
kober32 requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're getting there - some things can be simplified and some improved, otherwise looks OK.

.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/Responses/WMTOperationListResponse.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/Attributes/WMTOperationAttributeImage.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/Screens/WMTPreApprovalScreen.swift Outdated Show resolved Hide resolved
...raMobileTokenSDK/Operations/Model/UserOperation/TemplateParser/WMTTemplateDetailVisual.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTOperationFormData.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTOperationUIData.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTResultTexts.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTTemplates.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDK/Operations/Model/UserOperation/WMTTemplates.swift Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 Awaiting requested review from kober32

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create WMTTemplates
2 participants
@Hopsaheysa @kober32