Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade React to v19 in demo #1280

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

nishu-murmu
Copy link
Contributor

@nishu-murmu nishu-murmu commented Dec 16, 2024

This closes #1268

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 638b543
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6761c0cfd4af32000858bce2
😎 Deploy Preview https://deploy-preview-1280--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (0137d79) to head (4dde0b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   81.18%   81.14%   -0.04%     
==========================================
  Files         128      128              
  Lines        6286     6286              
  Branches     1065     1067       +2     
==========================================
- Hits         5103     5101       -2     
- Misses       1168     1170       +2     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! We can ignore the failed check, just because this PR is a fork.

@aklinker1 aklinker1 changed the title chore: React 19 upgrade chore: Upgrade React template to v19 Dec 16, 2024
@aklinker1
Copy link
Collaborator

Do we also need to upgrade @wxt-dev/module-react?

@nishu-murmu
Copy link
Contributor Author

Do we also need to upgrade @wxt-dev/module-react?

I thought as we or rather you are developing, we might need latest version for testing purposes, as I've often used wxt-demo for fixing bugs and all,
Also just to be in sync with the latest version. If you feel otherwise then I'll revert it back.

@aklinker1
Copy link
Collaborator

aklinker1 commented Dec 16, 2024

I haven't looked into what's required for react 19, but if we're updating the template, then that's what devs will use in their projects and we need to update the module as well.

@nishu-murmu
Copy link
Contributor Author

nishu-murmu commented Dec 16, 2024

So this is correct right?

templates/react/package.json Outdated Show resolved Hide resolved
@aklinker1 aklinker1 changed the title chore: Upgrade React template to v19 chore: Upgrade React to v19 in demo Dec 17, 2024
@aklinker1 aklinker1 merged commit 79c9c89 into wxt-dev:main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update React Template to v19
2 participants