-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade React to v19 in demo #1280
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 81.18% 81.14% -0.04%
==========================================
Files 128 128
Lines 6286 6286
Branches 1065 1067 +2
==========================================
- Hits 5103 5101 -2
- Misses 1168 1170 +2
Partials 15 15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! We can ignore the failed check, just because this PR is a fork.
Do we also need to upgrade |
I thought as we or rather you are developing, we might need latest version for testing purposes, as I've often used wxt-demo for fixing bugs and all, |
I haven't looked into what's required for react 19, but if we're updating the template, then that's what devs will use in their projects and we need to update the module as well. |
So this is correct right? |
This closes #1268