Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ViewPropTypes will be removed from React Native #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sibelly
Copy link

@sibelly sibelly commented May 9, 2022

Fixes ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types' warning

…wPropTypes exported from 'deprecated-react-native-prop-types' warning
@bordernone
Copy link

Can this be merged?

@sibabale
Copy link

sibabale commented Aug 10, 2022

@olarra can someone please merge this PR?

@Brma1048
Copy link

We also need this fix, please can someone merge this PR @olarra

@eHallberg
Copy link

What is the holdup here?

@sibelly
Copy link
Author

sibelly commented Sep 20, 2022

Only those with write access to this repository can merge pull requests.
And I don't have it.

@eHallberg
Copy link

Yeah, probably dead.. I had to add one more import for it to work with RN 0.70
import {ViewPropTypes, TextPropTypes} from "deprecated-react-native-prop-types";
and replace
textStyle: Text.propTypes.style, textStyleFocused: Text.propTypes.style
to
textStyle: TextPropTypes.style, textStyleFocused: TextPropTypes.style,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants