Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widevine on aarch64 #1729

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

HiassofT
Copy link
Contributor

Description

The switch to hidden symbol visibility broke widevine on aarch64 as the functions in the aarch64 cdm_loader.cpp were no longer exported:

error <general>: AddOnLog: inputstream.adaptive: Initialize: Initialize: Failed to load library: /storage/.kodi/cdm/libwidevinecdm.so: undefined symbol: __aarch64_ldadd4_acq_rel

Add attributes to specify default visibility to those functions to make it work again.

Motivation and context

Make widevine work on aarch64 again

How has this been tested?

Playing ORF livestream with the ORF ON addon on RPi5 running LibreELEC 13

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

The switch to hidden symbol visibility broke widevine on aarch64
as the functions in cdm_loader.cpp were no longer exported.

Add attributes to specify default visibility to those functions
to make it work again.

Signed-off-by: Matthias Reichl <hias@horus.com>
@CastagnaIT
Copy link
Collaborator

thank you

@CastagnaIT CastagnaIT merged commit 28828e2 into xbmc:Piers Nov 18, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DRM: Widevine Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants