Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSTree] Add support to read subtitle codec #1733

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

CastagnaIT
Copy link
Collaborator

Description

Allow to read subtitile codec string from variant
and so avoid forcing webvtt codec

Motivation and context

on ISA Samples addon there is an example of HLS with ttml subtitle
immagine
HLS parser force webvtt so will result in corrupted subs

anyway with that sample stream the subtitles are broken after a video seek, this will not be fixed here

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Improvement non-breaking change which improves existing functionality Component: Subtitles Component: HLS v22 Piers labels Nov 25, 2024
@CastagnaIT CastagnaIT merged commit 63e433d into xbmc:Piers Nov 26, 2024
8 of 10 checks passed
@CastagnaIT CastagnaIT deleted the hls_sub_codec branch November 26, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: HLS Component: Subtitles Type: Improvement non-breaking change which improves existing functionality v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant