Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skin.aeon.nox.silvo] v9.1.2 #425

Merged
merged 1 commit into from
Jan 7, 2024
Merged

[skin.aeon.nox.silvo] v9.1.2 #425

merged 1 commit into from
Jan 7, 2024

Conversation

MikeSiLVO
Copy link

Description

  • Bugfix for missing labels in AddonBrowser
  • Add favorites window to background customizer
  • Add fake slideshow to actor images to scroll left/right
  • Add Auto hide to Music OSD
  • Fix hiding logo for sets when hidden for movies in RightList view
  • Add TV Show duration using TMDb Helper to some areas

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@MikeSiLVO
Copy link
Author

Hey @ronie I remember you saying that you use KodiDevKit for Sublime Text to do skin checks. Not sure if you still do but I made some updates that should help with removing some false positives from missing attributes on some controls.

It works for me but I probably am missing some things since I just went by my own skin errors. I can try to update it with some more skin engine changes if you notice any other false positives :)

https://github.com/MikeSiLVO/KodiDevKit

@MikeSiLVO
Copy link
Author

I'll fix the news length

@MikeSiLVO
Copy link
Author

need to fix something...

@MikeSiLVO
Copy link
Author

Sorry about the quick turnaround on PRs. I had a stupid error that hid labels in AddonBrowser.

@ronie
Copy link
Member

ronie commented Jan 7, 2024

thanx, i'll check out your KodiDevKit updates, i'm sure they'll be useful for me as well.

@ronie ronie merged commit 0060751 into xbmc:nexus Jan 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants