Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skin.copacetic] 1.1.27 #435

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

realcopacetic
Copy link

Description

1.1.27

1.1.26

1.1.25

1.1.24

  • Disabled debugging flag

1.1.23

  • Fixed alignment bug and missing scrollbar on smartplaylisteditor window that could cause list of rules to exceed the sie of the panel broken playlist editor  realcopacetic/skin.copacetic#129
  • Added star rating widget to videoosd controls allowing user to view/set a userrating from videosd screen
  • Added language and subtitle quick toggles to videoosd screen

1.1.22

1.1.21

  • Added a fallback label for when clearlogo is not present in home screen background slideshow Add media title in home screen realcopacetic/skin.copacetic#120
  • Refined now playing expressions to make for better matching of currently displayed tv show/ season list item to videoplayer tvshowdibid. This will avoid two shows with the same name both showing as playing now when an episode from one is played Frasier Vs Frasier now playing  realcopacetic/skin.copacetic#100
  • Added studio flag for Mubi New studio flags realcopacetic/skin.copacetic#119
  • Added extra condition preventing windowopen animation on Home screen background artwork when returning to the homescreen immediately after ending playback of a video (Window.Previous(fullscreenvideo) + !Player.HasVideo). The reason for this is that, for an unknown reason, the window open animation was not triggering in this particular instance, causing the homescreen background not to load until navigating to another window and back to home.
  • Cleaned up some naming conventions between script.copacetic.helper and skin.copacetic

1.1.20

1.1.18-19

1.1.17

  • Fixed bug causing dialogaddoninformation to lose focus on opening for some addons
  • Added fade effect to infoscreen thumbnail when shutdownmenu visible on top
  • Added optional shutdown menu shortcut to hidden views menu The shutdown menu is difficult to access with a CEC TV remote realcopacetic/skin.copacetic#90
  • Fixed error in in skinshortcuts management window - non-existent control 309
  • Moved custom playlist background slideshow from homescreen to global via script.copacetic.helper 1.0.9
  • Rearranged skin settings to consolidate all background settings in one screen
  • When global background slideshow is showing or live tv is playing, removed fade in/out transitions between home, addonbrowser, settings screens, tvguide and tv/radio search for a smoother experience. This required removing Ken Burns effect from these background slideshows.
  • Removed some of the unnecessary transitions between different views when navigating through addonbrowser menus
  • Fixed multiart bug breaking artwork for billboard view in programs
  • Fixed typo breaking fix for previous issue Multiart not working on billboard home widgets realcopacetic/skin.copacetic#60
  • Fixed colour of volume indicator on home screen widgets when light theme selected
  • Added disabled indicator to addonbrowser for disabled addons in List and Grid views, plus installed indicator for installed addons when browsing repos
  • Redesigned script-upnext widget and added options to skinsettings to enable/disable addon and choose art type. NEXT UP  realcopacetic/skin.copacetic#102

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

- removal of execute permissions
@realcopacetic
Copy link
Author

Hi @ronie @Hitcher - after I removed those two files, the addon checker ran last night. It failed again, but this time I could see it was because the execute permissions were incorrectly set on all my files (because I had created them on Windows originally). So I fixed that and decided to make a clean PR - but it's failing again with the original complaint about incorrect format for 'skin.copacetic' before the addon checker is even run, which is confusing because last night it did run after those two files with the unsupported characters were removed.

@ronie
Copy link
Member

ronie commented Apr 5, 2024

i have no idea about the addon checker script, but this time it seems to be failing on these files:
"skin.copacetic/media/flags/studios/ARP S\303\251lection.png"
"skin.copacetic/media/flags/studios/B\303\263rd Scann\303\241n na H\303\251ireann.png"
"skin.copacetic/media/flags/studios/Cin\303\251art.png"
"skin.copacetic/media/flags/studios/Path\303\251.png"

@ronie
Copy link
Member

ronie commented Apr 5, 2024

since everything looks ok to me, i'm going to merge this regardless of the addon checker error.

@ronie ronie merged commit d9300dd into xbmc:nexus Apr 5, 2024
1 check failed
@realcopacetic
Copy link
Author

since everything looks ok to me, i'm going to merge this regardless of the addon checker error.

Thanks @ronie what do you use to check? I'll go through all the flag memes to check for illegal characters before next time

@Hitcher
Copy link

Hitcher commented Apr 5, 2024

I guess ronie either uses Skin XML Converter + Formatter or SublimeText3 plugin.

@ronie
Copy link
Member

ronie commented Apr 5, 2024

yup, i'm using the sublime plugin.
though as it's very old and unmaintained, it's not that useful anymore.

as for the addon checker error, i noticed it was failing on this command:

echo "addon=$(git diff --diff-filter=d --name-only HEAD~ | grep / | cut -d / -f1 | sort | uniq)"

so i ran that command (and a few variations of it) locally on your PR to figure out the issue.

@realcopacetic realcopacetic deleted the skin.copacetic-1.1.27 branch April 6, 2024 07:12
@realcopacetic
Copy link
Author

Thanks @ronie , I've not been able to get very far with SublimeText3 plugin unfortunately. I deleted those files, so hopefully next time it won't fail!

The reason I had them with the accents was because they were here so I thought that meant it was ok: https://github.com/XBMC-Addons/resource.images.studios.white/blob/master/resources/B%C3%B3rd%20Scann%C3%A1n%20na%20h%C3%89ireann.png
https://github.com/XBMC-Addons/resource.images.studios.white/blob/master/resources/Pathe%CC%81.png

@ronie
Copy link
Member

ronie commented Apr 8, 2024

it could be that the addon-checker script just can't handle those filesnames, i'm not sure.

as a recommendation from my end, you can also remove the studio flags from your skin
and instead depend on the resource.images.studios.white addon to provide those images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants