Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skin.copacetic-1.2.2~nexus] #444

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

realcopacetic
Copy link

Description

1.2.2

  • Non-breaking changes to keep code in sync with Omega
  • Cleaned some expressions governing Light theme and artwork backgrounds to simplify complex scenarios when several transparent windows are open on top of each other
  • Removed flash of light background when transitioning from fullscreen artwork background to fullscreen artwork infoscreen.
  • Removed some obsolete parameters
  • Fixed some instances when the primary colour was incorrectly used instead of the secondary colour on light background views when Light theme selected, causing things like scrollbars to be shown as white on white instead of black on white
  • Fixed a fadediffuse bug in the embedded list artwork mask used on Strip view
  • Fixed the missing Ken Burns effect from Billboard and List views with fullscreen artwork

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@realcopacetic
Copy link
Author

Here we are again @ronie with another failure, although for a different reason it seems like this time. I was going to submit to the omega repo as well, today, but I really want to get to the bottom of why this keeps failing

@ronie
Copy link
Member

ronie commented Apr 17, 2024

the error did not seem related to your skin,
so i re-ran the addon checker and now it fails at a different point.
it does not like the version number you use in addon.xml.

could you please stick to a simple numeric X.Y.Z version number?

removed ~nexus from addon version
@realcopacetic
Copy link
Author

Ahh sorry about that @ronie I must have misunderstood the documentation on version numbering, I've removed that and it seems to have done the trick!

@ronie ronie merged commit 79bbeba into xbmc:nexus Apr 19, 2024
1 check passed
@ronie
Copy link
Member

ronie commented Apr 19, 2024

thx!

@realcopacetic realcopacetic deleted the skin.copacetic-1.2.2-nexus branch May 13, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants