fix: BAM: Use lowercase skill names #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every use of the skill name, except one, turned it into a lowercase skill slug. And the one that didn't was a bug! Just make it lowercase in the action data to start with. The bug was in the getSkills() call, but it didn't matter since none of the actions that use it have MAP. I.e., it would try to look up `actor.skills.Crafting` and fail for the repair action, but the value would never be used since only the MAP variant code used it and repair has no MAP. The same for Aid and Raise a Shield, the only other call sites.
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every use of the skill name, except one, turned it into a lowercase skill slug. And the one that didn't was a bug!
Just make it lowercase in the action data to start with.
The bug was in the getSkills() call, but it didn't matter since none of the actions that use it have MAP. I.e., it would try to look up
actor.skills.Craftingand fail for the repair action, but the value would never be used since only the MAP variant code used it and repair has no MAP. The same for Aid and Raise a Shield, the only other call sites.follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines.)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
PR?)
Other information: