fix: Get rid of deprecation warning on settings submenus #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyzzy42
force-pushed
the
menu-select-deprecated
branch
from
93897e3 to
03b1320
Compare
Switch to new handlebars helper selectOptions as foundry has deprecated the select helper in V12. This one is simpler too.
xyzzy42
force-pushed
the
menu-select-deprecated
branch
from
03b1320 to
0eba4fc
Compare
|
🎉 This PR is included in version 6.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to new handlebars helper selectOptions as foundry has deprecated the select helper in V12. This one is simpler too.
follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines.)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
Warning when opening submenu.
What is the new behavior (if this is a feature change)?
No warning.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
PR?)
no
Other information: