Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Make an Impression with Performance to BAM #1512

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

xyzzy42
Copy link
Contributor

@xyzzy42 xyzzy42 commented Oct 30, 2024

This requires a feat. It's not the same as the alt skill check, as it's necessary to select which skill to use. So it should be another action, but only show if the feat is present.

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature.

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)

  • Other information:

This requires a feat.  It's not the same as the alt skill check, as it's
necessary to select which skill to use.  So it should be another action,
but only show if the feat is present.
@xdy xdy merged commit 9e69692 into xdy:main Oct 31, 2024
7 checks passed
Copy link

🎉 This PR is included in version 6.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@xyzzy42 xyzzy42 deleted the make-an-impression branch November 7, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants