Fix ForeignKeys in views, make it possible to use a database alias for synchronisation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I think code looks good, but I would appreciate some tests to test the behaviour before pushing it out |
Closed
|
Implemented in #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
This is a combination of https://github.com/mypebble/django-pgviews/pull/52/files and another fix that we use in production (ForeignKeys don't work properly with views unless deep copy is used on copied fields). Sorry for two things at once, but it'd just be nice to have it all upstreamed.
Paging @seroy who did both fixes.