Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for jpg orientation from photo or uploader #281

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

slup
Copy link

@slup slup commented Nov 9, 2024

When uploading pictures from my mobilephone, chyrp did not respect the EXIF orientation and showed the pictures with the wrong orientation.
This change rotates the uploaded (JPG-) image(s) to the orientation given in the EXIF information.

@xenocrat
Copy link
Owner

Hello there,

Thanks for taking the time to submit this PR.

Modern web browsers read and respect EXIF orientation metadata when displaying images, so I assume the root of your problem is with the way thumbnails are rendered using the thumbnail filter in Twig and/or ThumbnailFile class. I've decided not to merge this PR because I don't like the idea of modifying the source image during post creation; instead I'm going to add orientation support to the ThumbnailFile class. Your code will be very helpful for my implementation, so thank you again for submitting it!

I've created issue #282 to track this. I'll also leave this PR open for now.

xenocrat added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants