XCD-208 Make FastNavPlugin revert to the original canvas resolutionScale on switchToHighQuality #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ale on switchToHighQuality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
FastNavPlugin'sdefaultScaleCanvasResolutionFactorconstructor parameter is not used, theswitchToHighQualitywill switch back to the canvas's original resolution factor, instead of the hardcoded "fallback"1.0.After applying this change the following will set canvas's factor, and
FastNavPluginwill revert back to it (as would probably be expected):viewer.scene.canvas.resolutionScale = window.devicePixelRatio;