Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edgejs support #13

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: edgejs support #13

merged 1 commit into from
Sep 27, 2024

Conversation

Wilovy09
Copy link
Contributor

I'm not sure if that's enough to support it, but I think it is.
Also it would be nice to support edgejs
Zed won't let me open the dev extensions because of portals in linux.

@xhyrom
Copy link
Owner

xhyrom commented Sep 27, 2024

This is enough for this extension however zed only run LSP in provided languages (https://github.com/xhyrom/zed-discord-presence/blob/main/extension.toml#L12-L180). I think we need to wait until someone adds edge language support to zed.

@xhyrom xhyrom merged commit 2230b72 into xhyrom:main Sep 27, 2024
1 check passed
@Wilovy09
Copy link
Contributor Author

@xhyrom I'm working on supporting Edgejs, I've just never done it before so I need to learn it.

@xhyrom
Copy link
Owner

xhyrom commented Sep 27, 2024

nice, dont forget to ping me in the following PR in zed-industries so i can run my scraper for all languages again! ;)

wish you good luck!

@Wilovy09
Copy link
Contributor Author

Wilovy09 commented Oct 1, 2024

@xhyrom Will this be enough?
Repo: https://github.com/Wilovy09/zed-edgejs
image

@xhyrom
Copy link
Owner

xhyrom commented Oct 2, 2024

Yeah! I'll add it today.

PS: don't forget to also add this extension to official https://github.com/zed-extensions/extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants