fido2: use JSON encoding #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xi
force-pushed
the
main
branch
2 times, most recently
from
ffc38fd
to
5f5f460
Compare
xi
force-pushed
the
main
branch
2 times, most recently
from
ccb7982
to
a989df1
Compare
xi
force-pushed
the
main
branch
4 times, most recently
from
2b4c3ed
to
7be4d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON serialization was recently added to the webauthn editors draft. python-fido2 added support in 1.1.0.
This would provide better (standardized) solutions for #1 and #10. However, currently this would still require a polyfill. Therefor this would be a breaking change.
I think I will hold this off until this is available in browsers or at least until this has gained significant traction.