Skip to content

Commit

Permalink
Merge pull request ClickHouse#51405 from ClickHouse/status-lambdas
Browse files Browse the repository at this point in the history
Fix broken labeling for `manual approve`
  • Loading branch information
Felixoid committed Jun 26, 2023
2 parents 97f76d7 + 065b87a commit 32e671d
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions tests/ci/workflow_approve_rerun_lambda/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ def approve_run(workflow_description: WorkflowDescription, token: str) -> None:


def label_manual_approve(pull_request, token):
url = f"{pull_request['url']}/labels"
data = {"labels": "manual approve"}
url = f"{pull_request['issue_url']}/labels"
data = {"labels": ["manual approve"]}

_exec_post_with_retry(url, token, data)

Expand Down Expand Up @@ -376,11 +376,10 @@ def main(event):
changed_files = get_changed_files_for_pull_request(pull_request, token)
print(f"Totally have {len(changed_files)} changed files in PR:", changed_files)
if check_suspicious_changed_files(changed_files):
print(
f"Pull Request {pull_request['number']} has suspicious changes, "
"label it for manuall approve"
)
label_manual_approve(pull_request, token)
print(f"Pull Request {pull_request['number']} has suspicious changes")
if "manual approve" not in labels:
print("Label the PR as needed for manuall approve")
label_manual_approve(pull_request, token)
else:
print(f"Pull Request {pull_request['number']} has no suspicious changes")
approve_run(workflow_description, token)
Expand Down

0 comments on commit 32e671d

Please sign in to comment.