Skip to content

Commit

Permalink
[fix](delete_predicate) fix wrong data after upgrade from v2.0 version (
Browse files Browse the repository at this point in the history
  • Loading branch information
cambyzju committed Sep 9, 2024
1 parent ca38271 commit dc706ed
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion be/src/olap/delete_handler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,20 @@ Status DeleteHandler::init(TabletSchemaSPtr tablet_schema,
for (const auto& in_predicate : delete_condition.in_predicates()) {
TCondition condition;
condition.__set_column_name(in_predicate.column_name());
auto col_unique_id = in_predicate.column_unique_id();

int32_t col_unique_id = -1;
if (in_predicate.has_column_unique_id()) {
col_unique_id = in_predicate.column_unique_id();
} else {
// if upgrade from version 2.0.x, column_unique_id maybe not set
const auto& pre_column =
*DORIS_TRY(delete_pred_related_schema->column(condition.column_name));
col_unique_id = pre_column.unique_id();
}
if (col_unique_id == -1) {
return Status::Error<ErrorCode::DELETE_INVALID_CONDITION>(
"cannot get column_unique_id for column {}", condition.column_name);
}
condition.__set_column_unique_id(col_unique_id);

if (in_predicate.is_not_in()) {
Expand Down

0 comments on commit dc706ed

Please sign in to comment.