Skip to content

Commit

Permalink
Support Immediate Exit
Browse files Browse the repository at this point in the history
  • Loading branch information
lu-zero committed Aug 10, 2021
1 parent 9b53c84 commit 73572a9
Show file tree
Hide file tree
Showing 7 changed files with 61 additions and 15 deletions.
2 changes: 2 additions & 0 deletions src/api/channel/by_gop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ fn workerpool<T: Pixel>(
wl.send.send(p).unwrap();
}
Err(EncoderStatus::Encoded) => {}
Err(EncoderStatus::ImmediateExit) => break,
_ => todo!("Error management {:?}", r),
}
}
Expand All @@ -178,6 +179,7 @@ fn workerpool<T: Pixel>(
Ok(p) => wl.send.send(p).unwrap(),
Err(EncoderStatus::LimitReached) => break,
Err(EncoderStatus::Encoded) => {}
Err(EncoderStatus::ImmediateExit) => break,
_ => todo!("Error management"),
}
}
Expand Down
4 changes: 4 additions & 0 deletions src/api/config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,10 @@ impl Config {
inner.rc_state.setup_second_pass(s);
}

if let Some(ref progress) = self.progress {
inner.progress = Arc::clone(progress);
}

Ok(inner)
}

Expand Down
25 changes: 21 additions & 4 deletions src/api/internal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ use std::fs;
use std::path::PathBuf;
use std::sync::Arc;

use super::{DefaultProgress, GranularProgress};

/// The set of options that controls frame re-ordering and reference picture
/// selection.
/// The options stored here are invariant over the whole encode.
Expand Down Expand Up @@ -257,6 +259,9 @@ pub(crate) struct ContextInner<T: Pixel> {
next_lookahead_output_frameno: u64,
/// Optional opaque to be sent back to the user
opaque_q: BTreeMap<u64, Opaque>,

/// Progress callback
pub(crate) progress: Arc<dyn GranularProgress>,
}

impl<T: Pixel> ContextInner<T> {
Expand Down Expand Up @@ -309,6 +314,7 @@ impl<T: Pixel> ContextInner<T> {
next_lookahead_frame: 1,
next_lookahead_output_frameno: 0,
opaque_q: BTreeMap::new(),
progress: Arc::new(DefaultProgress {}) as Arc<dyn GranularProgress>,
}
}

Expand Down Expand Up @@ -1162,8 +1168,13 @@ impl<T: Pixel> ContextInner<T> {

if self.rc_state.needs_trial_encode(fti) {
let mut trial_fs = frame_data.fs.clone();
let data =
encode_frame(&frame_data.fi, &mut trial_fs, &self.inter_cfg);
let data = encode_frame(
&frame_data.fi,
&mut trial_fs,
&self.inter_cfg,
self.progress.as_ref(),
)
.ok_or(EncoderStatus::ImmediateExit)?;
self.rc_state.update_state(
(data.len() * 8) as i64,
fti,
Expand All @@ -1181,8 +1192,14 @@ impl<T: Pixel> ContextInner<T> {
frame_data.fi.set_quantizers(&qps);
}

let data =
encode_frame(&frame_data.fi, &mut frame_data.fs, &self.inter_cfg);
let data = encode_frame(
&frame_data.fi,
&mut frame_data.fs,
&self.inter_cfg,
self.progress.as_ref(),
)
.ok_or(EncoderStatus::ImmediateExit)?;

let enc_stats = frame_data.fs.enc_stats.clone();
self.maybe_prev_log_base_q = Some(qps.log_base_q);
// TODO: Add support for dropping frames.
Expand Down
3 changes: 3 additions & 0 deletions src/api/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ pub enum EncoderStatus {
/// [`Context::twopass_out()`]: struct.Context.html#method.twopass_out
#[error("not ready")]
NotReady,
/// Immediate exit was requested
#[error("immediate exit")]
ImmediateExit,
}

/// Represents a packet.
Expand Down
3 changes: 3 additions & 0 deletions src/bin/rav1e.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ fn process_frame<T: Pixel, D: Decoder>(
Err(e @ EncoderStatus::NotReady) => {
(Err(e.context("Mismanaged handling of two-pass stats data")), false)
}
Err(e @ EncoderStatus::ImmediateExit) => {
(Err(e.context("Immediate exit requested")), false)
}
Err(EncoderStatus::Encoded) => (Ok(Some(frame_summaries)), true),
};

Expand Down
4 changes: 4 additions & 0 deletions src/capi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ pub enum EncoderStatus {
/// was provided in the second pass of a 2-pass encode to encode the next
/// frame.
NotReady = -2,
/// Immediate exit requested
ImmediateExit = -3,
}

impl EncoderStatus {
Expand All @@ -137,6 +139,7 @@ impl EncoderStatus {
Encoded => "A Frame had been encoded but not emitted yet\0".as_ptr(),
Failure => "Generic fatal error\0".as_ptr(),
NotReady => "First-pass stats data not retrieved or not enough second-pass data provided\0".as_ptr(),
ImmediateExit => "Immediate exit requested\0".as_ptr(),
}
}
}
Expand All @@ -152,6 +155,7 @@ impl From<Option<rav1e::EncoderStatus>> for EncoderStatus {
rav1e::EncoderStatus::Encoded => EncoderStatus::Encoded,
rav1e::EncoderStatus::Failure => EncoderStatus::Failure,
rav1e::EncoderStatus::NotReady => EncoderStatus::NotReady,
rav1e::EncoderStatus::ImmediateExit => EncoderStatus::ImmediateExit,
},
}
}
Expand Down
35 changes: 24 additions & 11 deletions src/encoder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2973,7 +2973,8 @@ fn get_initial_cdfcontext<T: Pixel>(fi: &FrameInvariants<T>) -> CDFContext {
#[hawktracer(encode_tile_group)]
fn encode_tile_group<T: Pixel>(
fi: &FrameInvariants<T>, fs: &mut FrameState<T>, inter_cfg: &InterConfig,
) -> Vec<u8> {
progress: &dyn GranularProgress,
) -> Option<Vec<u8>> {
let planes =
if fi.sequence.chroma_sampling == ChromaSampling::Cs400 { 1 } else { 3 };
let mut blocks = FrameBlocks::new(fi.w_in_b, fi.h_in_b);
Expand All @@ -2988,12 +2989,18 @@ fn encode_tile_group<T: Pixel>(
.zip(cdfs.iter_mut())
.collect::<Vec<_>>()
.into_par_iter()
.map(|(mut ctx, cdf)| {
let raw = encode_tile(fi, &mut ctx.ts, cdf, &mut ctx.tb, inter_cfg);
(raw, ctx.ts)
.map(|(ctx, cdf)| {
let TileContextMut { mut ts, mut tb, .. } = ctx;
let raw = encode_tile(fi, &mut ts, cdf, &mut tb, inter_cfg, progress);
raw.map(|raw| (raw, ts))
})
.while_some()
.unzip();

if raw_tiles.len() != ti.tile_count() {
return None;
}

let stats =
tile_states.into_iter().map(|ts| ts.enc_stats).collect::<Vec<_>>();
for tile_stats in stats {
Expand Down Expand Up @@ -3078,7 +3085,7 @@ fn encode_tile_group<T: Pixel>(
debug_assert!(max_tile_size_bytes > 0 && max_tile_size_bytes <= 4);
fs.max_tile_size_bytes = max_tile_size_bytes;

build_raw_tile_group(ti, &raw_tiles, max_tile_size_bytes)
Some(build_raw_tile_group(ti, &raw_tiles, max_tile_size_bytes))
}

fn build_raw_tile_group(
Expand Down Expand Up @@ -3206,8 +3213,8 @@ fn check_lf_queue<T: Pixel>(
fn encode_tile<'a, T: Pixel>(
fi: &FrameInvariants<T>, ts: &mut TileStateMut<'_, T>,
fc: &'a mut CDFContext, blocks: &'a mut TileBlocksMut<'a>,
inter_cfg: &InterConfig,
) -> Vec<u8> {
inter_cfg: &InterConfig, progress: &dyn GranularProgress,
) -> Option<Vec<u8>> {
let mut w = WriterEncoder::new();
let planes =
if fi.sequence.chroma_sampling == ChromaSampling::Cs400 { 1 } else { 3 };
Expand All @@ -3226,6 +3233,11 @@ fn encode_tile<'a, T: Pixel>(
for sbx in 0..ts.sb_width {
cw.fc_log.clear();

let data = ProgressData {};
if !progress.progress(&data) {
return None;
}

let tile_sbo = TileSuperBlockOffset(SuperBlockOffset { x: sbx, y: sby });
let mut sbs_qe = SBSQueueEntry {
sbo: tile_sbo,
Expand Down Expand Up @@ -3402,7 +3414,7 @@ fn encode_tile<'a, T: Pixel>(
ts.sbo.0.x,
ts.sbo.0.y
);
w.done()
Some(w.done())
}

#[allow(unused)]
Expand Down Expand Up @@ -3485,7 +3497,8 @@ fn get_initial_segmentation<T: Pixel>(

pub fn encode_frame<T: Pixel>(
fi: &FrameInvariants<T>, fs: &mut FrameState<T>, inter_cfg: &InterConfig,
) -> Vec<u8> {
progress: &dyn GranularProgress,
) -> Option<Vec<u8>> {
debug_assert!(!fi.show_existing_frame);
debug_assert!(!fi.invalid);
let obu_extension = 0;
Expand All @@ -3496,7 +3509,7 @@ pub fn encode_frame<T: Pixel>(
fs.segmentation = get_initial_segmentation(fi);
segmentation_optimize(fi, fs);
}
let tile_group = encode_tile_group(fi, fs, inter_cfg);
let tile_group = encode_tile_group(fi, fs, inter_cfg, progress)?;

if fi.frame_type == FrameType::KEY {
write_key_frame_obus(&mut packet, fi, obu_extension).unwrap();
Expand Down Expand Up @@ -3527,7 +3540,7 @@ pub fn encode_frame<T: Pixel>(
buf2.clear();

packet.write_all(&tile_group).unwrap();
packet
Some(packet)
}

pub fn update_rec_buffer<T: Pixel>(
Expand Down

0 comments on commit 73572a9

Please sign in to comment.