Use region dimensions in SAD and ME #3097
Conversation
shssoichiro
force-pushed
the
maj-optim-10
branch
from
fc03f98 to
e14fa64
Compare
Codecov ReportBase: 86.77% // Head: 86.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
+ Coverage 86.77% 86.80% +0.03%
==========================================
Files 83 83
Lines 33105 33098 -7
==========================================
+ Hits 28727 28732 +5
+ Misses 4378 4366 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shssoichiro
force-pushed
the
maj-optim-10
branch
from
e14fa64 to
c2c7a7a
Compare
|
It seems that some of the assumptions do not hold in certain circumstances. To investigate, I would revert the parts where width and height parameters are removed and assert that they match the region dimensions. |
|
This is going to be rather painful to debug given that it only seems to be failing on x64 Macos. Why that is, I have no clue... I'll fix it up when I have a moment. |
This avoids having to re-check bounds every time we perform SAD, as the region knows its own size. It also may save 2 usize's being passed around during ME. To enforce this, we also remove the w and h parameters from everywhere. This is part of a series of commits authored by @maj160 to improve performance of rav1e.
shssoichiro
force-pushed
the
maj-optim-10
branch
from
98994ef to
bc171d7
Compare
This avoids having to re-check bounds every time we perform SAD, as the region knows its own size. It also may save 2 usize's being passed around during ME. To enforce this, we also remove the w and h parameters from everywhere.
This is part of a series of commits authored by @maj160 to improve performance of rav1e.