Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix issue#741 #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rihitenLab
Copy link

Sorry for the ugly English.

I tried to fix the issue #741 .
This issue can happen frequently, so consider merging.

Cause

There are two cause for this issue:

  1. In changeCurrentIndexProgressive in didSelectItemAt, OldCell is nil, because OldCell is off the screen.

  2. cellForItemAt is called when an OldCell outside the screen enters the screen with moveTo.
    However, the currentIndex has not been updated, the OldCell is determined to be a NewCell.

Amendment policy

The fix was applied only inside the buttonBar related sources. Because of the following two reasons

  1. We also considered modifying PagerTabStripViewController, but the scope of influence is too wide.

  2. changeCurrentIndexProgressive exists only in buttonBar.

@rihitenLab
Copy link
Author

I'm sorry.
I found an omission, so please wait for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants