Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VerifySmartContractWalletSignatureRequestSignature #216

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Add VerifySmartContractWalletSignatureRequestSignature #216

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a90f540
update signature verification request message
codabrink Oct 7, 2024
482b925
create parent payload for sig request
codabrink Oct 7, 2024
80c0db9
flatten the verification reqeust
codabrink Oct 7, 2024
acfe337
tweak name
codabrink Oct 7, 2024
fc6ef79
return block number in validation response
codabrink Oct 7, 2024
3a82d25
this can error out, leaving out a block_number
codabrink Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions proto/identity/api/v1/identity.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,25 @@ service IdentityApi {
}

message VerifySmartContractWalletSignaturesRequest {
repeated UnverifiedSmartContractWalletSignature signatures = 1;
repeated VerifySmartContractWalletSignatureRequestSignature signatures = 1;
}

message UnverifiedSmartContractWalletSignature {
xmtp.identity.associations.SmartContractWalletSignature scw_signature = 1;
// SHA256 hash of the signature payload
bytes hash = 5;
message VerifySmartContractWalletSignatureRequestSignature {
// CAIP-10 string
// https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-10.md
string account_id = 1;
// Specify the block number to verify the signature against
optional uint64 block_number = 2;
// The signature bytes
bytes signature = 3;
bytes hash = 4;
}

message VerifySmartContractWalletSignaturesResponse {
message ValidationResponse {
bool is_valid = 1;
optional string error = 2;
optional uint64 block_number = 2;
optional string error = 3;
}

repeated ValidationResponse responses = 1;
Expand Down
Loading