Payer API Refactor #223
Payer API Refactor #223
Conversation
| @@ -159,9 +102,9 @@ service ReplicationApi { | |||
| } | |||
|
|
|||
| // Publish envelope | |||
| rpc PublishEnvelopes(PublishEnvelopesRequest) returns (PublishEnvelopesResponse) { | |||
| rpc PublishPaidEnvelopes(PublishPaidEnvelopesRequest) returns (PublishPaidEnvelopesResponse) { | |||
There was a problem hiding this comment.
I didn't want to have two APIs named PublishEnvelopes that expect different request/response types. That feels like a footgun.
This is the best name I could come up with.
There was a problem hiding this comment.
I'm wondering if PublishPayerEnvelopes and PublishClientEnvelopes would be more consistent?
| @@ -159,9 +102,9 @@ service ReplicationApi { | |||
| } | |||
|
|
|||
| // Publish envelope | |||
| rpc PublishEnvelopes(PublishEnvelopesRequest) returns (PublishEnvelopesResponse) { | |||
| rpc PublishPaidEnvelopes(PublishPaidEnvelopesRequest) returns (PublishPaidEnvelopesResponse) { | |||
There was a problem hiding this comment.
I'm wondering if PublishPayerEnvelopes and PublishClientEnvelopes would be more consistent?
That was my #2 choice, but I don't really have a strong preference. Happy to switch it over. |
## tl;dr - Companion PR to xmtp/proto#223 which updates everything to the new format
|
🎉 This PR is included in version 3.72.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tl;dr
PublishEnvelopestoPublishPaidEnvelopesand adds a newPublishUnpaidEnvelopesAPI