Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contract Wallets #403

Merged
merged 38 commits into from
Oct 23, 2024
Merged

Smart Contract Wallets #403

merged 38 commits into from
Oct 23, 2024

Conversation

nplasterer
Copy link
Contributor

Create an account with a smart contract wallet.

@nplasterer nplasterer self-assigned this Sep 20, 2024
Sources/XMTPiOS/Client.swift Outdated Show resolved Hide resolved
Sources/XMTPiOS/SigningKey.swift Outdated Show resolved Hide resolved
@nplasterer nplasterer changed the base branch from main to np/stream-groups-logging September 26, 2024 05:34
Base automatically changed from np/stream-groups-logging to main September 26, 2024 13:30
@nplasterer nplasterer marked this pull request as ready for review October 21, 2024 15:32
@nplasterer nplasterer requested a review from a team as a code owner October 21, 2024 15:32
@@ -514,4 +521,28 @@ class ClientTests: XCTestCase {
let newState = try await alixClient3.inboxState(refreshFromNetwork: true)
XCTAssertEqual(newState.installations.count, 1)
}

func testCreatesASCWClient() async throws {
throw XCTSkip("TODO: Need to write a SCW local deploy with anvil")
Copy link
Contributor Author

@nplasterer nplasterer Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent a bunch of time trying to get a SCW running locally like I did in Android. But I'm just not as familiar with the tooling in iOS and I time boxed it. Will revisit when I have more time. Will use the example in RN to validate.

Code should be identical to Android so I feel confident.

@nplasterer nplasterer merged commit 3b31d0f into main Oct 23, 2024
2 checks passed
@nplasterer nplasterer deleted the np/smart-contract-wallets branch October 23, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants