Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: len for groupby #533

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

RayJi01
Copy link
Contributor

@RayJi01 RayJi01 commented Jun 16, 2023

What do these changes do?

Inplement len Operands for groupby Object. e.g. calling len(grouped_object)

Related issue number

Fixes #442

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.3.2 milestone Jun 16, 2023
@qianduoduo0904 qianduoduo0904 changed the title Feature/len for groupby Feature: len for groupby Jun 16, 2023
@qianduoduo0904 qianduoduo0904 changed the title Feature: len for groupby EHN: len for groupby Jun 16, 2023
@XprobeBot XprobeBot removed the feature label Jun 16, 2023
@qianduoduo0904 qianduoduo0904 changed the title EHN: len for groupby ENH: len for groupby Jun 16, 2023
@XprobeBot XprobeBot added the enhancement New feature or request label Jun 16, 2023
@RayJi01 RayJi01 marked this pull request as draft June 16, 2023 10:24
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #533 (0cf151b) into main (895af3b) will increase coverage by 3.87%.
The diff coverage is 98.38%.

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   89.80%   93.67%   +3.87%     
==========================================
  Files        1008     1009       +1     
  Lines       77917    77979      +62     
  Branches    16170    16179       +9     
==========================================
+ Hits        69971    73046    +3075     
+ Misses       6143     3298    -2845     
+ Partials     1803     1635     -168     
Flag Coverage Δ
unittests 93.56% <98.38%> (+3.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/_mars/dataframe/groupby/len.py 98.27% <98.27%> (ø)
python/xorbits/_mars/dataframe/groupby/__init__.py 96.55% <100.00%> (+0.12%) ⬆️
python/xorbits/_mars/opcodes.py 100.00% <100.00%> (ø)

... and 128 files with indirect coverage changes

@RayJi01 RayJi01 marked this pull request as ready for review June 28, 2023 08:51
@XprobeBot XprobeBot modified the milestones: v0.3.2, v0.4.1 Jul 1, 2023
@XprobeBot XprobeBot modified the milestones: v0.4.1, Temp Jul 10, 2023
@aresnow1 aresnow1 removed this from the Temp milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Groupby object does not implement len() method
4 participants