Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix some warning caused by deprecation #804

Merged
merged 17 commits into from
Sep 18, 2024

Conversation

hucorz
Copy link
Collaborator

@hucorz hucorz commented Aug 26, 2024

What do these changes do?

  • fix some warning in _mars/dataframe/indexing
  • fix fillna's warning caused by method param

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 26, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.98%. Comparing base (9984250) to head (e6bb347).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
+ Coverage   82.97%   82.98%   +0.01%     
==========================================
  Files        1070     1070              
  Lines       80004    80031      +27     
  Branches    16537    16528       -9     
==========================================
+ Hits        66380    66414      +34     
+ Misses      12031    12020      -11     
- Partials     1593     1597       +4     
Flag Coverage Δ
unittests 82.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hucorz hucorz changed the title ENH: Fix fillna warning ENH: Fix some warning caused by deprecation Aug 27, 2024
@luweizheng luweizheng self-requested a review September 18, 2024 22:27
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit c765e57 into xorbitsai:main Sep 18, 2024
32 of 34 checks passed
@hucorz hucorz deleted the fix-fillna-warning branch October 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants