Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Compatible with NumPy 2.x #817

Merged
merged 49 commits into from
Oct 14, 2024
Merged

Conversation

Dawnfz-Lenfeng
Copy link
Contributor

@Dawnfz-Lenfeng Dawnfz-Lenfeng commented Oct 1, 2024

What do these changes do?

  • Modified all interfaces to adapt to NumPy 2.x, while maintaining compatibility with versions below 2.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Oct 1, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (5b471fb) to head (f6d6983).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
+ Coverage   82.96%   83.02%   +0.06%     
==========================================
  Files        1071     1071              
  Lines       80083    80113      +30     
  Branches    16545    12200    -4345     
==========================================
+ Hits        66439    66514      +75     
+ Misses      12038    12033       -5     
+ Partials     1606     1566      -40     
Flag Coverage Δ
unittests 82.92% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng marked this pull request as draft October 6, 2024 03:39
@luweizheng luweizheng changed the title ENH: Update Interfaces for NumPy 2.x ENH: Compatible with NumPy 2.x Oct 14, 2024
@luweizheng luweizheng marked this pull request as ready for review October 14, 2024 08:12
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 9700db7 into xorbitsai:main Oct 14, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants