Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: disable import cuda error when cpu only in a shared python env #47

Merged

Conversation

ChengjieLi28
Copy link
Contributor

Shared python environments that contain cuda-related environments but do not actually have GPU environments on the machine only show warnings.

Fixes xorbitsai/xorbits#595

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added bug Something isn't working gpu labels Jul 14, 2023
@XprobeBot XprobeBot added this to the v0.0.9 milestone Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #47 (7a7335a) into main (7db36a2) will decrease coverage by 3.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   93.84%   90.23%   -3.61%     
==========================================
  Files          42       42              
  Lines        3361     3358       -3     
  Branches      672      349     -323     
==========================================
- Hits         3154     3030     -124     
- Misses        136      244     +108     
- Partials       71       84      +13     
Flag Coverage Δ
unittests 90.23% <ø> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

aresnow1
aresnow1 previously approved these changes Jul 17, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit a7c94f7 into xorbitsai:main Jul 17, 2023
13 checks passed
ChengjieLi28 added a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: all the import cuda error should be disabled when setting cuda_devices=None in init
4 participants