Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: generator support normal function #83

Merged

Conversation

codingl2k1
Copy link
Contributor

What do these changes do?

  • If a normal function is decorated by xo.generator, then the function will be run by to_threads.
  • Regardless of whether a function is decorated by xo.generator returns a generator or an async generator or a value, the function should works as expected.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v1.0.0 milestone Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a442021) 89.12% compared to head (5d346f6) 89.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   89.12%   89.02%   -0.10%     
==========================================
  Files          48       48              
  Lines        4010     4010              
  Branches      764      764              
==========================================
- Hits         3574     3570       -4     
- Misses        351      355       +4     
  Partials       85       85              
Flag Coverage Δ
unittests 88.85% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aresnow1 aresnow1 merged commit 4d623f4 into xorbitsai:main Jan 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants