Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rf: more idiomatic health endpoint #34

Merged
merged 1 commit into from
Jun 10, 2024
Merged

rf: more idiomatic health endpoint #34

merged 1 commit into from
Jun 10, 2024

Conversation

kynrai
Copy link
Collaborator

@kynrai kynrai commented Jun 10, 2024

  • Move health check to server
  • Use go struct and marshalling instead of hard code json string, allows for easily adding future fields e.g. Version, build date, DB status etc
  • Sort handlers

@kynrai kynrai requested a review from Lissy93 as a code owner June 10, 2024 12:18
@kynrai kynrai requested review from Lissy93 and removed request for Lissy93 June 10, 2024 12:18
@codecov Codecov
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 54.13% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/server.go 0.00% <0.00%> (ø)
server/middleware.go 0.00% <0.00%> (ø)

@Lissy93 Lissy93 merged commit 38d31e2 into main Jun 10, 2024
2 of 3 checks passed
@kynrai kynrai deleted the rf/healthcheck_endpoint branch June 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kynrai @Lissy93