feat: add aws sessionToken support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xseman , Thanks |
xseman
reviewed
Nov 9, 2024
|
Thank you for your contribution! LGTM. |
faisal-hameed
force-pushed
the
feature/aws-session-token-support
branch
from
9fdebd4 to
1c42132
Compare
|
I can't get test workflow to work, maybe secrets are it's limited to local branches, I tested your branch manually tests passed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for AWS session tokens, which are necessary when using temporary security credentials. The following changes have been made:
Code Update: Added sessionToken to the configuration in index.ts to enable authentication with temporary credentials.
Documentation Update: Updated the README to include information about the sessionToken, specifying its type and usage.
These changes ensure that our application can authenticate using temporary AWS credentials, enhancing security and flexibility.