Link to xsleaks discord #155
Conversation
themes/book/layouts/404.html
Outdated
| @@ -29,7 +29,6 @@ <h3> | |||
| </main> | |||
|
|
|||
| {{ partial "docs/inject/body" . }} | |||
| {{ template "_internal/google_analytics_async.html" . }} | |||
There was a problem hiding this comment.
This deletion doesn't seem to be related to the PR?
There was a problem hiding this comment.
Removing this was required to pass the test.
There was a problem hiding this comment.
The diff looks okay now :)
|
|
Would you prefer just a invite link instead of the widget? |
I think that the widget looks too invasive. I also looked whether there are some alternatives and the only one I found was a light theme that has the same problem (with the exception that it fits better the light theme). Also, since you enabled the widget for the discord, it's now leaking its users and their status which I'm not fan of.. XS-Leaks wiki embedding a discord XS-Leak would be a bit ironic :) So yes, the invite link is a better choice in my opinion. |
|
Okay just use https://discord.com/invite/w3SV2zP6mz I won't be able to make
the change myself for a couple days, add it yourself if that's easier
(Suggested text looks file)
…On Sun, Apr 21, 2024, 8:33 PM terjanq ***@***.***> wrote:
Would you prefer just a invite link instead of the widget?
I think that the widget looks too invasive. I also looked whether there
are some alternatives and the only one I found was a light theme that has
the same problem (with the exception that it fits better the light theme).
Also, since you enabled the widget for the discord, it's now leaking its
users and their status which I'm not fan of.. XS-Leaks wiki embedding a
discord XS-Leak would be a bit ironic :)
—
Reply to this email directly, view it on GitHub
<#155 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHQZ74KKHVYWLSABKATN7DLY6QIAZAVCNFSM6AAAAABGL6WR2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGE3TIOJSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Okay, done. |
No description provided.