#417: Catastrophic failure when no tests pass the filter

xunit · Sep 13, 2024 · d72ef51 · d72ef51
1 parent a5a6808
commit d72ef51
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/xunit.runner.visualstudio/VsTestRunner.cs b/src/xunit.runner.visualstudio/VsTestRunner.cs
@@ -590,6 +590,15 @@ await DiscoverTestsInAssembly(
 					}
 				}
 
+				// https://github.com/xunit/visualstudio.xunit/issues/417
+				if (testCaseSerializations.Count == 0)
+				{
+					if (configuration.InternalDiagnosticMessagesOrDefault)
+						logger.LogWarning("Skipping '{0}': no tests passed the filter", assemblyFileName);
+
+					return;
+				}
+
 				// Execute tests
 				var executionOptions = TestFrameworkOptions.ForExecution(configuration);
 				if (!configuration.ParallelizeTestCollectionsOrDefault)