#426: Can't filter by traits on ITheoryDataRow

xunit · Dec 5, 2024 · d94ab88 · d94ab88
1 parent 9154f3f
commit d94ab88
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/xunit.runner.visualstudio/VsTestRunner.cs b/src/xunit.runner.visualstudio/VsTestRunner.cs
@@ -207,9 +207,9 @@ async Task DiscoverTests<TVisitor>(
 					ConfigReader.Load(assembly.Configuration, assembly.AssemblyFileName, assembly.ConfigFileName, configWarnings);
 					runSettings.CopyTo(assembly.Configuration);
 
-					// IDE users get pre-enumeated theories by default
-					if (testPlatformContext.DesignMode)
-						assembly.Configuration.PreEnumerateTheories ??= true;
+					// Pre-enumerate theories by default, so that we can see all traits, including those that come from
+					// ITheoryDataRow in v3. See: https://github.com/xunit/visualstudio.xunit/issues/426
+					assembly.Configuration.PreEnumerateTheories ??= true;
 
 					foreach (var warning in configWarnings)
 						logger.LogWarning("{0}", warning);