fix UsingParamAnonymousConstructor

xuwei-k · Jan 4, 2025 · fb69458 · fb69458
1 parent 13c3a95
commit fb69458
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/input/src/main/scala-3/fix/UsingParamAnonymousConstructorTest.scala b/input/src/main/scala-3/fix/UsingParamAnonymousConstructorTest.scala
@@ -10,6 +10,12 @@ trait UsingParamAnonymousConstructorTest {
     def f: Int = x1
   }
 
+  class A3(using val x1: Int)
+
+  class A4(using var x1: Int)
+
+  class A5(using @annotation.nowarn x1: Int)
+
   trait B1(using x1: Int)
 
   trait B2(using x1: Int) {

diff --git a/output/src/main/scala-3/fix/UsingParamAnonymousConstructorTest.scala b/output/src/main/scala-3/fix/UsingParamAnonymousConstructorTest.scala
@@ -7,6 +7,12 @@ trait UsingParamAnonymousConstructorTest {
     def f: Int = x1
   }
 
+  class A3(using val x1: Int)
+
+  class A4(using var x1: Int)
+
+  class A5(using @annotation.nowarn x1: Int)
+
   trait B1(using  Int)
 
   trait B2(using x1: Int) {

diff --git a/rules/src/main/scala/fix/UsingParamAnonymousConstructor.scala b/rules/src/main/scala/fix/UsingParamAnonymousConstructor.scala
@@ -17,7 +17,7 @@ class UsingParamAnonymousConstructor extends SyntacticRule("UsingParamAnonymousC
       val t = c.ctor
       t.paramClauses.filter { paramClause =>
         paramClause.values.forall(_.mods.exists(_.is[Mod.Using])) && paramClause.values.forall(m =>
-          !m.mods.exists(_.is[Mod.Inline]) && !m.mods.exists(_.is[Mod.Annot])
+          !m.mods.exists(x => x.is[Mod.Inline] || x.is[Mod.Annot] || x.is[Mod.ValParam] || x.is[Mod.VarParam])
         )
       }.map { paramClause =>
         val countOneNames = c.collect { case x: Term.Name =>