Merge branch 'hotfix/v0.1.0.1'

Changelog.md

@@ -1,3 +1,8 @@
+# 0.1.0.1
+
+* Regression fix: 500 for deleted reshares introduced by the locator
+* Federate locations
+
 # 0.1.0.0
 
 ## Refactor

app/models/location.rb

@@ -1,12 +1,17 @@
 class Location < ActiveRecord::Base
-
-  before_validation :split_coords, :on => :create
+  before_validation :split_coords, on: :create
+  validates_presence_of :lat, :lng
 
   attr_accessor :coordinates
 
+  include Diaspora::Federated::Base
+  xml_attr :address
+  xml_attr :lat
+  xml_attr :lng
+
   belongs_to :status_message
 
   def split_coords
-    coordinates.present? ? (self.lat, self.lng = coordinates.split(',')) : false
+    self.lat, self.lng = coordinates.split(',') if coordinates.present?
   end
 end

app/models/reshare.rb

@@ -80,7 +80,7 @@ def absolute_root
   end
 
   def address
-    absolute_root.location.try(:address)
+    absolute_root.try(:location).try(:address)
   end
 
   private

app/models/status_message.rb

@@ -15,6 +15,7 @@ class StatusMessage < Post
   xml_name :status_message
   xml_attr :raw_message
   xml_attr :photos, :as => [Photo]
+  xml_attr :location, :as => Location
 
   has_many :photos, :dependent => :destroy, :foreign_key => :status_message_guid, :primary_key => :guid
 

config/defaults.yml

@@ -4,7 +4,7 @@
 
 defaults:
   version:
-    number: "0.1.0.0" # Do not touch unless doing a release, do not backport the version number that's in master but keep develp to always say "head"
+    number: "0.1.0.1" # Do not touch unless doing a release, do not backport the version number that's in master but keep develp to always say "head"
   heroku: false
   environment:
     url: "http://localhost:3000/"

spec/models/status_message_spec.rb

@@ -329,6 +329,29 @@
         end
       end
     end
+
+    context 'with a location' do
+      before do
+        @message.location = Location.new(coordinates: "1, 2").tap(&:save)
+        @xml = @message.to_xml.to_s
+      end
+
+      it 'serializes the location' do
+        @xml.should include "location"
+        @xml.should include "lat"
+        @xml.should include "lng"
+      end
+
+      describe ".from_xml" do
+        before do
+          @marshalled = StatusMessage.from_xml(@xml)
+        end
+
+        it 'marshals the location' do
+          @marshalled.location.should be_present
+        end
+      end
+    end
   end
 
   describe '#after_dispatch' do