Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query tag for http_request_total #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nutsoriginal
Copy link

I found that README.md has example of http_request_total with query tag

http_request_total{host="dev.to",port="443",method="GET",query="/amplifr"} 145.0

But actual code does not have this tag

@Envek
Copy link
Member

Envek commented Jul 12, 2023

Hey, thanks for the pull request.

One thing that bother me here is that query value can have very high and practically unlimited number of possible values, and monitoring systems doesn't like high cardinality time series (for an example see Prometheus' docs for metric labels). So it can be a bit dangerous.

@dsalahutdinov, can you recall any details on query tag absense from implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants