Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tvl page #247

Merged
merged 4 commits into from Aug 19, 2021
Merged

Added tvl page #247

merged 4 commits into from Aug 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2021 •
edited by ghost
Loading

@ethedev ethedev linked an issue Aug 9, 2021 that may be closed by this pull request
Add TVL page #243
Open
@ethedev ethedev added the cannot merge Not to be deployed yet label Aug 11, 2021
@rossgalloway
Copy link
Contributor

If we are going to show TVL, shouldnt we show the TVL in YAM synths? This seems like much more important TVL than what is in our incentivizer.

Also, other TVL aggregators look at our synth TVL. See defillama here: https://defillama.com/protocol/yam-finance. Their code is wrong, and is looking at an old assets.json (https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/degenerative/index.js). Can we update that and re-use their code?

@ethedev
Copy link
Member

ethedev commented Aug 13, 2021

@rossgalloway this tvl will be the combined tvl across all yam products

@ethedev ethedev merged commit 0435330 into yam-finance:develop Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cannot merge Not to be deployed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TVL page
2 participants
@rossgalloway @ethedev