update default method to check if element displayed to always return … #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a boolean and handle exceptions
| } catch (Exception e) { | ||
| //ignore and return false to indicate element is not visible. | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Here you're presuming that if element isn't found (this is when exception is thrown), then it's invisible. But this is hiding that fact (that element wasn't found) from the developer who runs the tests and therefore I think it's not the right way to handle this.
Instead you should be catching that exception in place where you call isDisplayed method.
|
test this please |
…d to always return and added unit test
|
I think it would be better to add separate method for that. See PR #91. |
| @@ -208,7 +208,12 @@ public WebElement findElement(By by) { | |||
| */ | |||
| @Override | |||
| public boolean isDisplayed() { | |||
| return wrappedElement.isDisplayed(); | |||
| try{ | |||
| return getWrappedElement().isDisplayed(); | |||
There was a problem hiding this comment.
Either log or rethrow this exception. 
|
SonarQube analysis reported 2 issues:
Watch the comments in this conversation to review them. |
| return getWrappedElement().isDisplayed(); | ||
| try{ | ||
| return getWrappedElement().isDisplayed(); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Either log or rethrow this exception.
eroshenkoam
force-pushed
the
master
branch
2 times, most recently
from
58b45bf
to
1c8583b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a boolean and handle exceptions