add TextInput.setText #90
Conversation
| * @param newValue New value for this text input. | ||
| */ | ||
| public void setText(String newValue) { | ||
| getWrappedElement().sendKeys(getClearCharSequence() + newValue); |
There was a problem hiding this comment.
I think instead the getClearCharSequence() + should be added to TextInput.sendKeys method. This way everybody who wants to change input value has no need to prepend it.
There was a problem hiding this comment.
That would break backward compatibility and would be counterintuitive.
Also there may be situations when you don't want to clear anything, you just want to press a key.
|
Add some tests please |
|
There are tests for |
|
If you move logic of deleting text to setText method, you should move corresponding tests as well. |
| @Test | ||
| public void setTextShouldNotAddClearKeysForTextInputWithEmptyText() { | ||
| when(webElement.getAttribute("value")).thenReturn(""); | ||
| textInput.setText("qwerty"); |
There was a problem hiding this comment.
where is assertion for this test?
|
👍 (just need to fix merge issue) |
| @@ -37,6 +37,15 @@ public void sendKeys(CharSequence... keys) { | |||
| } | |||
|
|
|||
| /** | |||
| * Sets this text input's value. | |||
There was a problem hiding this comment.
Perhaps be explicit about using getClearCharSequence() and not using clear()?
No description provided.