Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc compilation errors #300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix gcc compilation errors #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8325326
Avoid gcc errors about not implemented string literal operator templates
elsid Jan 18, 2021
4aba895
Update googletest to fix gcc error
elsid Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ExternalProject_Add(
include_directories(SYSTEM ${CMAKE_CURRENT_BINARY_DIR}/include)

# enable a bunch of warnings and make them errors
target_compile_options(ozo_benchmark PRIVATE -Wall -Wextra -Wsign-compare -pedantic -Werror)
target_compile_options(ozo_benchmark PRIVATE -Wall -Wextra -Wsign-compare -Werror)

# ignore specific error for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand All @@ -37,7 +37,7 @@ target_link_libraries(ozo_benchmark_performance ozo)
target_link_libraries(ozo_benchmark_performance Boost::program_options)

# enable a bunch of warnings and make them errors
target_compile_options(ozo_benchmark_performance PRIVATE -Wall -Wextra -Wsign-compare -pedantic -Werror)
target_compile_options(ozo_benchmark_performance PRIVATE -Wall -Wextra -Wsign-compare -Werror)

# ignore specific error for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand Down
10 changes: 5 additions & 5 deletions examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ add_executable(ozo_request request.cpp)
target_link_libraries(ozo_request ozo)

# enable a bunch of warnings and make them errors
target_compile_options(ozo_request PRIVATE -Wall -Wextra -Wsign-compare -pedantic -Werror)
target_compile_options(ozo_request PRIVATE -Wall -Wextra -Wsign-compare -Werror)

# ignore specific errors for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand All @@ -20,7 +20,7 @@ add_executable(ozo_transaction transaction.cpp)
target_link_libraries(ozo_transaction ozo)

# enable a bunch of warnings and make them errors
target_compile_options(ozo_transaction PRIVATE -Wall -Wextra -Wsign-compare -pedantic -Werror)
target_compile_options(ozo_transaction PRIVATE -Wall -Wextra -Wsign-compare -Werror)

# ignore specific errors for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand All @@ -31,7 +31,7 @@ add_executable(ozo_retry_request retry_request.cpp)
target_link_libraries(ozo_retry_request ozo)

# enable a bunch of warnings and make them errors
target_compile_options(ozo_retry_request PRIVATE -Wall -Wextra -Wsign-compare -pedantic -Werror)
target_compile_options(ozo_retry_request PRIVATE -Wall -Wextra -Wsign-compare -Werror)

# ignore specific errors for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand All @@ -42,7 +42,7 @@ add_executable(ozo_role_based_request role_based_request.cpp)
target_link_libraries(ozo_role_based_request ozo)

# enable a bunch of warnings and make them errors
target_compile_options(ozo_role_based_request PRIVATE -Wall -Wextra -Wsign-compare -pedantic -Werror)
target_compile_options(ozo_role_based_request PRIVATE -Wall -Wextra -Wsign-compare -Werror)

# ignore specific errors for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand All @@ -53,7 +53,7 @@ add_executable(ozo_connection_pool connection_pool.cpp)
target_link_libraries(ozo_connection_pool ozo)

# enable a bunch of warnings and make them errors
target_compile_options(ozo_connection_pool PRIVATE -Wall -Wextra -Wsign-compare -pedantic -Werror)
target_compile_options(ozo_connection_pool PRIVATE -Wall -Wextra -Wsign-compare -Werror)

# ignore specific errors for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand Down
4 changes: 2 additions & 2 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ include(ExternalProject)
ExternalProject_Add(
GoogleTest
GIT_REPOSITORY "https://github.com/google/googletest.git"
GIT_TAG release-1.10.0
GIT_TAG aa533abfd4232b01f9e57041d70114d5a77e6de0
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_CURRENT_BINARY_DIR}
UPDATE_COMMAND ""
LOG_DOWNLOAD ON
Expand Down Expand Up @@ -88,7 +88,7 @@ if(CCACHE_FOUND)
endif()

# enable useful warnings and errors
target_compile_options(ozo_tests PRIVATE -Wall -Wextra -pedantic -Werror)
target_compile_options(ozo_tests PRIVATE -Wall -Wextra -Werror)

# ignore specific errors for clang
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
Expand Down
2 changes: 1 addition & 1 deletion tests/external_project/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ project(my_ozo_using_project)

find_package(ozo REQUIRED)
add_executable(my_app ../../examples/request.cpp warning_option_propagation.cpp)
target_compile_options(my_app PRIVATE -Wall -Wextra -pedantic -Werror)
target_compile_options(my_app PRIVATE -Wall -Wextra -Werror)
target_link_libraries(my_app PRIVATE yandex::ozo)