-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strapi v5 compatibility #59
Conversation
#24 should not be an issue as long as users have email defined in AzureAD. The problem is that email is just not mandatory in Azure AD |
ac10e59
to
de5c8aa
Compare
@delemeator yes you're right, I was having a similar problem but it was unrelated (using an HTTPS proxy is broken in axios/https and that was causing the request to fail and therefore the SSO fail in the same way as described in that issue). I was able to test it with AzureAD and have been using the updated extension without problems on Strapi v5 RC11 for a few days now. @yasudacloud do you prefer to wait for Strapi to release the first stable version before merging or to merge this into the branch and keep that updated? |
@marc0777 |
f056a50
to
595c172
Compare
@marc0777 I would like to make some changes to the v5 branch on my end, so I would like to merge it once, is that OK? |
I haven't written here anymore because since RC18 the plugin stopped working, and it doesn't run with the stable version either. If you want to merge and start working on it yourself feel free to do so! :) Just a couple of notes:
I'll be available in case you need more information. |
@marc0777 By the way, regarding strapi/sdk-plugin#60 , I encountered a similar error while writing another plugin in TypeScript. |
Yes, using dynamic imports worked here too but it looks like an hack and I hope it's not the approach "officially" recommended by Strapi. |
Hello, I've refactored the plugin to use ES Module syntax, now all imports are working correctly and the syntax is much cleaner too. I've tested this in Strapi 5.0.1 and everything seems to be working! |
@marc0777 However, there were a few things I wanted to fix, so I will try to fix them on my end as well. |
Support for Strapi v5, currently tested on RC11, fixes #58.
I set it as draft as there are a few things that I have to look into. I tested it with Autentik and it was working correctly, now looking into testing it with AzureAD (probably will need to also fix #24 for that to work).
Will update it as soon as I as I have news, with also a bit of explanation on how to use this, since since Strapi v5 plugins should be built.