Final Exam Part 2 Tests added and Small Function Changes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e skips in vessel_spec and am working on making the tests pass
…f different types
… volume associated with them
…water, can be filled and can dispense the water in its reservoir
…the freezer, calculate the remaining capacity of the freezer and set the temperature based on the level
…e very similar layouts and similar changes were needed to make them complient, the most notable change that isn't from what is required from tests is the fact chiller goes by 5's per level of temperature and freezer goes by 10's per level
…mbined total of freezer and chiller capacity
…no longer empty when items are added to them through their respective methods, though I would've prefered to use an expect include test so that we could make sure items were contained in the contents of the freezer and chiller, but there was an error I could not resolve, commiting this message to remember later
…rator, changed refrigerator to access power symbol
…e by showing they also turn off with the refridgerator
…ring, before and after changes are made through adding items
…negative and if it does need to drain will drain only to a level of 0
…negative when given a number higher than the volume of water currently contained
… a vessel, based on the dispense function, changed some tests so that instead of using no parameters they use one for the volume to fill the reservoir to, no behavior has been changed that can be noticed by the user, though there have been many changes to some names and to some of the methods, such as changing the fill method in the WaterDispenser so that it takes a vessel and uses that vessels volume for the int to fill the resevoir to
…t be filled beyond the reservoir capacity
…r so that it can't be initialized with a volume above the set capacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added many tests for each spec file, and changed small portions of functions, both for the assignment and small changes to variable names for ease of understanding.