Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS362 - Gavin Gutowsky Final - Pull Request #2

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

CS362 - Gavin Gutowsky Final - Pull Request #2

wants to merge 21 commits into from

Commits on Mar 18, 2021

  1. bundle install

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5351d8c View commit details
    Browse the repository at this point in the history

  2. Add required arguments to class instantiation

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a22c5de View commit details
    Browse the repository at this point in the history

  3. Vessel: add name attribute reader

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    1401ecb View commit details
    Browse the repository at this point in the history

  4. Vessel: empty? implementation

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    230b6c6 View commit details
    Browse the repository at this point in the history

  5. Vessel: fixed expectation

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ab17477 View commit details
    Browse the repository at this point in the history

  6. Vessel: fill implementation and empty refactor to match implementation

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    1ca6f4a View commit details
    Browse the repository at this point in the history

  7. Vessel spec: reversal of expectation and removal of skip of fill test

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    50bb5d0 View commit details
    Browse the repository at this point in the history

  8. Item: instantiation test

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    3a22aaa View commit details
    Browse the repository at this point in the history

  9. Item: let instantiation block for further use

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5a1309e View commit details
    Browse the repository at this point in the history

  10. Item: attribute name validation

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    af52b75 View commit details
    Browse the repository at this point in the history

  11. Item: attribute volume validation

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    2ed7d51 View commit details
    Browse the repository at this point in the history

  12. WaterDispenser: instantiation test

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5f482ed View commit details
    Browse the repository at this point in the history

  13. WaterDispenser: attribute reservoir validation

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    7e7f673 View commit details
    Browse the repository at this point in the history

  14. WaterDispenser: remove dependency on vessel

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    3a6d548 View commit details
    Browse the repository at this point in the history

  15. WaterDispenser: correct reservoir spelling

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    23d20f5 View commit details
    Browse the repository at this point in the history

  16. WaterReservoir: unit test implementations 

    Sorry for single large commit, ran out of time and rushed tests
    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b95f1fb View commit details
    Browse the repository at this point in the history

  17. Revert refactor 

    oops, legacy code
    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0bcc632 View commit details
    Browse the repository at this point in the history

  18. Vessel: Refactor for filling

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    e6a30d0 View commit details
    Browse the repository at this point in the history

  19. WaterDispenser: refactor for vessel filling

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ea4282e View commit details
    Browse the repository at this point in the history

  20. WaterReservoir: Add check for overdrain and test check

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ca007d7 View commit details
    Browse the repository at this point in the history

  21. WaterDispenser: implementation of dispense test

    @GavinGutowsky
    GavinGutowsky committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    cd0ac0a View commit details
    Browse the repository at this point in the history